Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Set the correct MagicPython package dependency #1426

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set the correct MagicPython package dependency #1426

wants to merge 1 commit into from

Conversation

@fed
Copy link

@fed fed commented Dec 31, 2017 •
edited
Loading

After installing Nuclide I've set it to automatically fetch and install all recommended packages. However, I've had this alert popping up every single time I opened Nuclide:

image

It looked like the MagicPython package was getting installed, but it actually wasn't (btw I'm running Atom 1.23.1, Nuclide 0.273.0 on MacOS High Sierra).

Tried installing it manually running apm install MagicPython but it errored out:

Installing MagicPython to /Users/fknussel/.atom/packages ✓
fs.js:640
  return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode);
                 ^

Error: ENOENT: no such file or directory, open '/Users/fknussel/.atom/packages/MagicPython/package.json'
    at Error (native)
    at Object.fs.openSync (fs.js:640:18)
    at Proxy.fs.readFileSync (fs.js:508:33)
    at Proxy.fs.readFileSync (/private/var/folders/4j/6cfp1zxj6_x9ywq8g_nj3b8m0000gn/T/AppTranslocation/4FCD6043-6D3C-464A-B0B9-FF1FCD713E7C/d/Atom.app/Contents/Resources/app/apm/node_modules/asar-require/lib/require.js:86:27)
    at /private/var/folders/4j/6cfp1zxj6_x9ywq8g_nj3b8m0000gn/T/AppTranslocation/4FCD6043-6D3C-464A-B0B9-FF1FCD713E7C/d/Atom.app/Contents/Resources/app/apm/lib/install.js:476:42
    at fn (/private/var/folders/4j/6cfp1zxj6_x9ywq8g_nj3b8m0000gn/T/AppTranslocation/4FCD6043-6D3C-464A-B0B9-FF1FCD713E7C/d/Atom.app/Contents/Resources/app/apm/node_modules/async/lib/async.js:582:34)
    at Immediate.<anonymous> (/private/var/folders/4j/6cfp1zxj6_x9ywq8g_nj3b8m0000gn/T/AppTranslocation/4FCD6043-6D3C-464A-B0B9-FF1FCD713E7C/d/Atom.app/Contents/Resources/app/apm/node_modules/async/lib/async.js:498:34)
    at runCallback (timers.js:649:20)
    at tryOnImmediate (timers.js:622:5)
    at processImmediate [as _immediateCallback] (timers.js:594:5)

Not sure what's the deal with case sensitivity when it comes to Atom packages, but switching to the lowercase name version (as per the package site) seemed to do the trick:

apm install magicpython

Never got the "installing MagicPython" alert message again on boot up.

Not sure this is just me, but anyway I reckon this should be changed to reflect the actual name of the package.

@facebook-github-bot
Copy link

facebook-github-bot commented Dec 31, 2017

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link

facebook-github-bot commented Dec 31, 2017

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fed @facebook-github-bot